Skip to content

fix(users): improve recently active search - #48559

Merged
Altahrim merged 3 commits into
masterfrom
fix/recently_active_pgsql
Oct 30, 2024
Merged

fix(users): improve recently active search#48559
Altahrim merged 3 commits into
masterfrom
fix/recently_active_pgsql

Conversation

@Altahrim

@AltahrimAltahrim commented Oct 3, 2024

Copy link
Copy Markdown
Collaborator

Summary

  • Remove DISTINCT clause to fix PgSQL
  • Use data from users only if necessary (search)
  • Don't show people who never connected in active list
  • Add test
  • Add hard limit on list (100 users max)

TODO

  • badge still count all users instead of actives ones

Checklist

@AltahrimAltahrim self-assigned this Oct 3, 2024
@AltahrimAltahrim added bug 2. developing Work in progress labels Oct 3, 2024
@Altahrim

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable30

@Altahrim
Altahrim requested review from a team, ArtificialOwl, artonge and come-nc and removed request for a teamOctober 3, 2024 14:34
@Altahrim
Altahrim marked this pull request as ready for review October 3, 2024 14:34
Comment threadtests/lib/User/ManagerTest.php Outdated
@Altahrim
Altahrimforce-pushed the fix/recently_active_pgsql branch from 787de53 to efa4ea1CompareOctober 8, 2024 15:30
@Altahrim
Altahrimforce-pushed the fix/recently_active_pgsql branch 9 times, most recently from 3287967 to b0f7fe8CompareOctober 16, 2024 09:54
@Altahrim
Altahrimforce-pushed the fix/recently_active_pgsql branch 2 times, most recently from 157fd45 to 22061d1CompareOctober 17, 2024 07:37
@Altahrim
Altahrimforce-pushed the fix/recently_active_pgsql branch from 22061d1 to b0e22baCompareOctober 24, 2024 12:25
@artonge
artongeforce-pushed the fix/recently_active_pgsql branch 4 times, most recently from 6f585ca to 9c11ec8CompareOctober 24, 2024 16:51
@Altahrim
Altahrimforce-pushed the fix/recently_active_pgsql branch 7 times, most recently from c463a32 to cb83cefCompareOctober 29, 2024 16:39
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the fix/recently_active_pgsql branch from cb83cef to 49bd175CompareOctober 30, 2024 06:53
@Altahrim
Altahrim enabled auto-merge October 30, 2024 07:51
@Altahrim
Altahrim merged commit dac15d1 into masterOct 30, 2024
@Altahrim
Altahrim deleted the fix/recently_active_pgsql branch October 30, 2024 09:09
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: accounts -> recently active does not work on pgsql

3 participants

@Altahrim@artonge@come-nc