Skip to content

Fix email share transfer accross storages - #48597

Merged
come-nc merged 3 commits into
masterfrom
fix/fix-email-share-transfer-accross-storages
Oct 8, 2024
Merged

Fix email share transfer accross storages#48597
come-nc merged 3 commits into
masterfrom
fix/fix-email-share-transfer-accross-storages

Conversation

@come-nc

@come-nccome-nc commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Summary

Follow-up of #44904 to fix email shares.

Checklist

Makes debbuging way easier
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This fixes transfering an email share from a user to another one when using
objectstore as primary storage.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc added the 3. to review Waiting for reviews label Oct 7, 2024
@come-nccome-nc added this to the Nextcloud 31 milestone Oct 7, 2024
@come-nc
come-nc requested a review from susnuxOctober 7, 2024 13:39
@come-nccome-nc self-assigned this Oct 7, 2024
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@susnux
susnux requested review from a team, Altahrim, icewind1991 and provokateurin and removed request for a teamOctober 7, 2024 19:06

/*
* We allow updating the permissions and password of mail shares
* We allow updating mail shares

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO Things like this should not be checked in "mappers" but only in the controllers.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc@susnux@provokateurin