Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix: Return correct list of managers for a user - #48622
Merged
Conversation
artonge
approved these changes
Oct 9, 2024
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
backport/48538/stable30
branch
from
October 9, 2024 21:53
9d43f66 to
221f7a3ComparePytal
marked this pull request as ready for review
October 9, 2024 21:54
Pytal
approved these changes
Oct 9, 2024
| $currentLoggedInUser = $this->userSession->getUser(); | ||
| $managerUids = $user->getManagerUids(); | ||
| if ($this->groupManager->isAdmin($currentLoggedInUser->getUID()) || $this->groupManager->isDelegatedAdmin($currentLoggedInUser->getUID())) { |
Check notice
Code scanning / Psalm
PossiblyNullReference
| return $managerUids; | ||
| } | ||
| if ($this->subAdminManager->isSubAdmin($currentLoggedInUser)) { |
Check notice
Code scanning / Psalm
PossiblyNullArgument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48538
Warning, This backport's changes differ from the original and might be incomplete⚠️ Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.