Skip to content

fix(dav): Public WebDAV endpoint should allow GET requests - #48628

Merged
provokateurin merged 1 commit into
masterfrom
fix/public-get
Oct 9, 2024
Merged

fix(dav): Public WebDAV endpoint should allow GET requests#48628
provokateurin merged 1 commit into
masterfrom
fix/public-get

Conversation

@susnux

@susnuxsusnux commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Summary

GET should be allowed even without Ajax header to allow downloading files, or show files in the viewer. All other requests could be guarded, but this should not.

I think this was copy-paste from the v1 implementation, but that did not provide GET support, so for the old endpoint it made sense. But now with GET support we need to allow browsers to access the files without custom headers.

Checklist

@susnux
susnux requested review from a team, ArtificialOwl, artonge and skjnldsv and removed request for a teamOctober 9, 2024 11:55
@susnuxsusnux added this to the Nextcloud 31 milestone Oct 9, 2024
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

`GET` should be allowed even without Ajax header to allow downloading files,
or show files in the viewer. All other requests could be guarded, but this should not.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@provokateurin
provokateurin merged commit 0b5f036 into masterOct 9, 2024
@provokateurin
provokateurin deleted the fix/public-get branch October 9, 2024 15:32
@backportbot

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/48628/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick bbc5d32c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48628/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Viewing media files via a share link doesn't work anymore

3 participants

@susnux@provokateurin@sorbaugh