Uh oh!
There was an error while loading. Please reload this page.
fix(files): Do not jump to top when fileId is set to currentFolder - #48632
Merged
Conversation
artonge
commented
Oct 9, 2024
CollaboratorAuthor
/backport to stable29 |
artonge
commented
Oct 9, 2024
CollaboratorAuthor
/backport to stable30 |
susnux
commented
Oct 9, 2024
Contributor
Seems like bandage (but ok for a quick fix I would say) I think the underlying issue is we have two properties for three states: States:
(3 is needed because of virtual scrolling to preserve the correct files in view). Properties that control the states:
So I think the best solution would be to add a new query part: So we end up with:
This would allow to reload the page at any state and the same view will be created as before the reload. What do you think @skjnldsv@artonge ? |
artonge
commented
Oct 9, 2024
CollaboratorAuthor
Maybe, but quick fix is enough 🙈. |
artonge
enabled auto-merge
October 9, 2024 18:14
skjnldsv
approved these changes
Oct 18, 2024
Pytal
approved these changes
Oct 21, 2024
Fix#48545 Signed-off-by: Louis Chemineau <louis@chmn.me>
skjnldsv
commented
Oct 29, 2024
Member
Rebased |
skjnldsvforce-pushed
the
artonge/fix/file_list_jump_on_viewer_close
branch
from
October 29, 2024 10:43
c79368f to
7b27d05Compareskjnldsv
disabled auto-merge
October 29, 2024 10:44
skjnldsv
enabled auto-merge
October 29, 2024 10:44
This was referenced Oct 29, 2024
This was referenced Oct 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#48545