Uh oh!
There was an error while loading. Please reload this page.
fix(updater): make clean-up job more robust / easier to debug - #48674
Merged
Conversation
Merged
AndyScherzingerforce-pushed
the
jtr/fix-updater-cleanup-job-logging
branch
from
February 5, 2025 19:39
431907f to
9b4554cCompareartonge
approved these changes
Feb 6, 2025
artongeforce-pushed
the
jtr/fix-updater-cleanup-job-logging
branch
from
February 6, 2025 09:36
9b4554c to
08a6bdeCompareSigned-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
jtr/fix-updater-cleanup-job-logging
branch
from
February 6, 2025 10:09
b0c2cf8 to
6744accCompareskjnldsv
approved these changes
Feb 6, 2025
come-nc
approved these changes
Feb 6, 2025
Merged
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On occasion there have been vague reports about the updater backup folder clean-up job (#9855) seemingly not, well, cleaning up. This adjusts the logging a bit and checks the return value of the deletions to give the admin (or us) a potentially better chance of figuring out what is going on.
TODO
Checklist