Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix(share): Return empty string if no label is set - #48739
Merged
Conversation
backportbotBot
requested review from
come-nc, kesselb, provokateurin and susnuxOctober 16, 2024 18:41
susnuxforce-pushed
the
backport/48673/stable28
branch
from
October 16, 2024 18:43
3af3365 to
f26d04fComparesusnux
approved these changes
Oct 16, 2024
susnux
marked this pull request as ready for review
October 16, 2024 18:43
susnux
enabled auto-merge
October 16, 2024 18:43
provokateurin
approved these changes
Oct 17, 2024
susnuxforce-pushed
the
backport/48673/stable28
branch
2 times, most recently
from
October 17, 2024 16:27
2bd160c to
bfde2a0Compare* Resolves: #48629 While the database supports NULL, the typing has always said it only returns *string*. So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
backport/48673/stable28
branch
from
October 17, 2024 16:48
bfde2a0 to
788233cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48673
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.