Skip to content

build: Print RTL limited characters in translation-checker - #48839

Merged
susnux merged 2 commits into
masterfrom
build/translation-checker-print-rtl-limited-characters
Oct 23, 2024
Merged

build: Print RTL limited characters in translation-checker#48839
susnux merged 2 commits into
masterfrom
build/translation-checker-print-rtl-limited-characters

Conversation

@provokateurin

@provokateurinprovokateurin commented Oct 22, 2024

Copy link
Copy Markdown
Member

Summary

So we know which characters are causing problems.

Checklist

@provokateurin
build: Print RTL limited characters in translation-checker
f660e4c
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurinprovokateurin added the 3. to review Waiting for reviews label Oct 22, 2024
@provokateurinprovokateurin added this to the Nextcloud 31 milestone Oct 22, 2024
@nickvergessen

nickvergessen commented Oct 23, 2024

Copy link
Copy Markdown
Member

Counter proposal:

$ php build/translation-checker.php ERROR: There were 1 errors:
…/apps/files/l10n/vi.json
Contains a RTL limited characters in the translations. Offending strings:
"Fill template fields" : "‎Thiết lập thư mục mẫu‎",

@nickvergessen
build: Show the actual string
61e3fa0
Signed-off-by: Joas Schilling <coding@schilljs.com>
@provokateurin

provokateurin commented Oct 23, 2024

Copy link
Copy Markdown
MemberAuthor

Makes sense 👍

@nickvergessen

nickvergessen commented Oct 23, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@nickvergessen

nickvergessen commented Oct 23, 2024

Copy link
Copy Markdown
Member

/backport to stable29

@nickvergessen

nickvergessen commented Oct 23, 2024

Copy link
Copy Markdown
Member

/backport to stable30

@susnux
susnux merged commit 2055516 into masterOct 23, 2024
@susnux
susnux deleted the build/translation-checker-print-rtl-limited-characters branch October 23, 2024 11:42
This was referenced Oct 23, 2024
Merged
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@susnuxsusnuxsusnux approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@nickvergessen@susnux