Skip to content

fix(app-store): Ensure the groups property is always an array - #48853

Merged
susnux merged 1 commit into
masterfrom
fix/app-store-groups
Oct 23, 2024
Merged

fix(app-store): Ensure the groups property is always an array#48853
susnux merged 1 commit into
masterfrom
fix/app-store-groups

Conversation

@susnux

@susnuxsusnux commented Oct 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

If the value was a string, like a single group, then json_decode will also yield only a string. So in this case we ensure the property is always an array with that value.

Checklist

@susnux
fix(app-store): Ensure the groups property is always an array
9955b13
If the value was a string, like a single group, then `json_decode` will also yield only a string.
So in this case we ensure the property is always an array with that value.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux added this to the Nextcloud 31 milestone Oct 23, 2024
@susnux
susnux requested review from a team, Altahrim, skjnldsv and yemkareems and removed request for a teamOctober 23, 2024 11:35
@susnux

susnux commented Oct 23, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnuxsusnux added the php Pull requests that update Php code label Oct 23, 2024
@susnux
susnux enabled auto-merge October 23, 2024 14:55
@susnux
susnux merged commit 1f17604 into masterOct 23, 2024
@susnux
susnux deleted the fix/app-store-groups branch October 23, 2024 15:04
@backportbotbackportbotBot mentioned this pull request Oct 23, 2024
Merged
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurinprovokateurinprovokateurin approved these changes
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner automatically assigned from nextcloud/server-backend
+1 more reviewer
@yemkareemsyemkareemsyemkareems approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: apps managementphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux@yemkareems@provokateurin