Skip to content

fix(files): add title for files list table header button - #48898

Merged
nickvergessen merged 2 commits into
masterfrom
fix/files--list-header-button-title
Oct 25, 2024
Merged

fix(files): add title for files list table header button#48898
nickvergessen merged 2 commits into
masterfrom
fix/files--list-header-button-title

Conversation

@ShGKme

Copy link
Copy Markdown
Contributor

In some languages 2 * --height is not enough to fit some table header button texts. Adding title.

I'm not a fun of having title all the time, but I don't see a simple alternative.

Screenshots

🏚️ Before🏡 After
imageimage

Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKmeShGKme added this to the Nextcloud 31 milestone Oct 25, 2024
@ShGKme
ShGKme requested review from Pytal and susnuxOctober 25, 2024 16:18
@ShGKmeShGKme self-assigned this Oct 25, 2024
@ShGKme
ShGKme requested a review from skjnldsv as a code ownerOctober 25, 2024 16:18
@nickvergessen
nickvergessen merged commit 7b36547 into masterOct 25, 2024
@nickvergessen
nickvergessen deleted the fix/files--list-header-button-title branch October 25, 2024 20:50
@nickvergessen

Copy link
Copy Markdown
Member

/backport f7498d0 to stable30

@nickvergessen

Copy link
Copy Markdown
Member

/backport f7498d0 to stable29

@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport f7498d0 to stable28

@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport f7498d0 to stable29

@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport f7498d0 to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ShGKme@nickvergessen@Pytal