Skip to content

fix(files_sharing): Cleanup error messages - #48918

Merged
provokateurin merged 1 commit into
masterfrom
fix/files_sharing/cleanup-error-messages
Oct 28, 2024
Merged

fix(files_sharing): Cleanup error messages#48918
provokateurin merged 1 commit into
masterfrom
fix/files_sharing/cleanup-error-messages

Conversation

@provokateurin

@provokateurinprovokateurin commented Oct 28, 2024

Copy link
Copy Markdown
Member

Summary

Checklist

@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels Oct 28, 2024
@provokateurinprovokateurin added this to the Nextcloud 31 milestone Oct 28, 2024
@provokateurin
provokateurin requested review from a team, artonge, skjnldsv and sorbaugh and removed request for a teamOctober 28, 2024 07:08
@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."

@provokateurin
provokateurinforce-pushed the fix/files_sharing/cleanup-error-messages branch from 64fd4eb to 53ddaa3CompareOctober 28, 2024 07:55
@provokateurin

Copy link
Copy Markdown
MemberAuthor

Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."

Fixed. The called method was already returning a proper error message, so I aligned all the uses of it.

Signed-off-by: provokateurin <kate@provokateurin.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@Altahrim@nfebe