Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Cleanup error messages - #48918
Merged
Merged
Conversation
provokateurin
requested review from
a team, artonge, skjnldsv and sorbaugh
and removed request for
a teamOctober 28, 2024 07:08
provokateurin
commented
Oct 28, 2024
MemberAuthor
/backport to stable30 |
provokateurin
commented
Oct 28, 2024
MemberAuthor
/backport to stable29 |
provokateurin
commented
Oct 28, 2024
MemberAuthor
/backport to stable28 |
nfebe
approved these changes
Oct 28, 2024
nfebe
left a comment
Contributor
There was a problem hiding this comment.
Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."
Altahrim
approved these changes
Oct 28, 2024
provokateurinforce-pushed
the
fix/files_sharing/cleanup-error-messages
branch
from
October 28, 2024 07:55
64fd4eb to
53ddaa3Compareprovokateurin
commented
Oct 28, 2024
MemberAuthor
Fixed. The called method was already returning a proper error message, so I aligned all the uses of it. |
provokateurin
enabled auto-merge
October 28, 2024 07:56
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurinforce-pushed
the
fix/files_sharing/cleanup-error-messages
branch
from
October 28, 2024 08:07
53ddaa3 to
aacb3ddCompare
This was referenced Oct 28, 2024
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist