Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix: encrypt and store password, decrypt and retrieve the same - #48939
Merged
Conversation
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…exception Signed-off-by: yemkareems <yemkareems@gmail.com>
…exception Signed-off-by: yemkareems <yemkareems@gmail.com> [skip ci]
yemkareems
marked this pull request as ready for review
October 28, 2024 12:37
provokateurin
marked this pull request as draft
October 28, 2024 13:12
Signed-off-by: yemkareems <yemkareems@gmail.com>
provokateurin
commented
Oct 28, 2024
Member
This is not ready for review, please fix the todos in the pr description first. |
yemkareems
marked this pull request as ready for review
October 28, 2024 13:59
yemkareems
approved these changes
Oct 28, 2024
provokateurin
approved these changes
Oct 28, 2024
6 tasks
mpractic
commented
Nov 7, 2024
Apparently this causes a critical bug that leaves NC down until you disable passwords and downgrade to the previous version: |
blizzz
commented
Nov 7, 2024
Member
This is an internal data structure, not an API or otherwise exposed. Passwords simply has to access the data differently. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48915
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.