Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Password field must not be required if already set - #48991
Merged
Conversation
susnux
commented
Oct 29, 2024
ContributorAuthor
/backport to stable30 |
susnux
commented
Oct 29, 2024
ContributorAuthor
/backport to stable29 |
susnuxforce-pushed
the
fix/password-field-sharing
branch
from
October 30, 2024 09:15
2c8b26f to
f984570CompareIf there is already a password, there is no need to require the password
in the setting ('newPassword'). It is only required for new shares.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/password-field-sharing
branch
from
October 30, 2024 09:31
f984570 to
e13b6d3Comparenfebe
approved these changes
Oct 30, 2024
nfebe
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Wondering what would happen if someone attempts to remove password on an existing share, if possible.
provokateurin
approved these changes
Oct 30, 2024
susnux
commented
Oct 30, 2024
ContributorAuthor
If the password is enforced, then this is not possible, you can only modify it. |
This was referenced Oct 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is already a password, there is no need to require the password in the setting ('newPassword'). It is only required for new shares.
Checklist