Skip to content

fix(ShareEntryLinkList): Append new links to the end of list - #49017

Merged
nfebe merged 2 commits into
masterfrom
fix/48415/do-not-rename-main-share-link
Oct 30, 2024
Merged

fix(ShareEntryLinkList): Append new links to the end of list#49017
nfebe merged 2 commits into
masterfrom
fix/48415/do-not-rename-main-share-link

Conversation

@nfebe

Copy link
Copy Markdown
Contributor

Currently new shares are added to beginning of the share list in the UI messing up the ordering with the original (first) looking like the most recent and the most recent looking like the original share. This error disappears on refresh.

Resolves : #48415

@nfebenfebe added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish feature: sharing labels Oct 30, 2024
@nfebe
nfebeforce-pushed the fix/48415/do-not-rename-main-share-link branch from 105d803 to 3cee516CompareOctober 30, 2024 13:55
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@nfebe

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@nfebe

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

Currently new shares are added to beginning of the share list in the UI
messing up the ordering with the original (first) looking like the most
recent and the most recent looking like the original share. This error
disappears on refresh.
Resolves : #48415
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the fix/48415/do-not-rename-main-share-link branch from 3cee516 to 0daacbeCompareOctober 30, 2024 13:57
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
7 queries added
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 7 queries added
- UPDATE "oc_filecache" SET "size" = :dcValue4 WHERE ("fileid" = :dcValue1) AND ("storage" = :dcValue2) AND (("size" <> :dcValue3) OR ("size" IS NULL))
- UPDATE "oc_filecache" SET "size" = :dcValue4 WHERE ("fileid" = :dcValue1) AND ("storage" = :dcValue2) AND (("size" <> :dcValue3) OR ("size" IS NULL))
- SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
- SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
+ SELECT "storage", "path", "mimetype" FROM "oc_filecache" WHERE "fileid" = :dcValue1
+ SELECT "storage_id", "root_id", "user_id", "mount_point", "mount_id", "f"."path", "mount_provider_class" FROM "oc_mounts" "m" INNER JOIN "oc_filecache" "f" ON "m"."root_id" = "f"."fileid" WHERE ("storage_id" = :dcValue1) AND ("user_id" = :dcValue2)
+ SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE ("filecache"."fileid" = :dcValue1) AND ("storage" = :dcValue2)
+ DELETE FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
+ DELETE FROM "oc_filecache_extended" WHERE "fileid" = :dcValue1
+ DELETE FROM "oc_files_metadata" WHERE "file_id" = :dcValue1
+ DELETE FROM "oc_files_metadata_index" WHERE "file_id" = :dcValue1
+ SELECT "json", "sync_token" FROM "oc_files_metadata" WHERE "file_id" = :dcValue1
+ SELECT "fileid" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("path_hash" = :dcValue2)
+ UPDATE "oc_file_locks" SET "lock" = :dcValue1, "ttl" = :dcValue2 WHERE ("key" = :dcValue3) AND ("lock" = :dcValue4)
+ SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE ("path_hash" = :dcValue1) AND ("storage" = :dcValue2)
= ./occ profiler:list

@nfebe
nfebe enabled auto-merge October 30, 2024 14:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews4. to releaseReady to be released and/or waiting for tests to finishfeature: sharing

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Adding a second share link "renames" the first one

4 participants

@nfebe@susnux@artonge@nextcloud-command