Fix logo being too big on log in page, fix #4585

[jancborchardt]

Please review @nextcloud/designers @MorrisJobke@MariusBluem@juliushaertl – it was caused by theming changes. Removing them makes theming still work, and fixes the issue with the logos being way too big, for example even touching the .warning box on error pages.

Before / after:

[mention-bot]

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl and @MorrisJobke to be potential reviewers.

[MorrisJobke]

Cuts of parts of the image if it is in portrait format. 👎

[codecov]

Codecov Report

Merging #4910 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #4910 +/- ##
============================================
+ Coverage 54.16% 54.16% +<.01% 
Complexity 22173 22173 ============================================
Files 1365 1365 Lines 84893 84885 -8 Branches 1322 1322 ============================================
Hits 45981 45981 + Misses 38912 38904 -8

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Security/CertificateManager.php	90.81% <0%> (-1.03%)	39% <0%> (ø)
lib/private/Server.php	93.4% <0%> (+0.14%)	120% <0%> (ø)	⬇️
tests/redis.config.php	10% <0%> (+4.44%)	0% <0%> (ø)	⬇️

[juliusknorr]

@jancborchardt I've added another commit to keep the logo stretched to the container when custom themed logos are used.

@MorrisJobke Was that what you were talking about above? Or is it a different issue?

[MorrisJobke]

@MorrisJobke Was that what you were talking about above? Or is it a different issue?

Yes - works now.

[MorrisJobke]

Tested and works now 👍

[LukasReschke]

@jancborchardt If you want this backported then please open a backport for stable12. Note that it likely will only be included with Nextcloud 12.0.1.

[juliusknorr]

I think we should backport this. PR at #4976