Skip to content

[stable30] fix(SharingEntryLink): Show default password before create if any - #49149

Merged
nfebe merged 3 commits into
stable30from
backport/49115/stable30
Nov 8, 2024
Merged

[stable30] fix(SharingEntryLink): Show default password before create if any#49149
nfebe merged 3 commits into
stable30from
backport/49115/stable30

Conversation

@backportbot

@backportbotbackportbotBot commented Nov 8, 2024

Copy link
Copy Markdown

Backport of #49115

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

nfebeand others added 3 commits November 8, 2024 16:20
Prevent silent addition of expiration date to shares.
Prevent silent addition for password to shares.
Both now have a `shareRequiresReview` check
Resolves : #48860
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the backport/49115/stable30 branch from 1d4fd9c to 9d62dffCompareNovember 8, 2024 15:20
@skjnldsv
skjnldsv marked this pull request as ready for review November 8, 2024 15:20
@skjnldsv

Copy link
Copy Markdown
Member

added 780362c (#49149) which fixes an issue the upstream PR created

@nfebe
nfebe merged commit cc1197d into stable30Nov 8, 2024
@nfebe
nfebe deleted the backport/49115/stable30 branch November 8, 2024 15:40
@nfebe

nfebe commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

/backport to stable29

@skjnldsvskjnldsv mentioned this pull request Nov 27, 2024
6 tasks
@nfebe

Copy link
Copy Markdown
Contributor

backport to stable29

@nfebe

Copy link
Copy Markdown
Contributor

/backport to stable29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@skjnldsv@nfebe