Uh oh!
There was an error while loading. Please reload this page.
fix(files): Properly reset all file list filters on view change - #49261
Merged
Conversation
susnux
requested review from
a team, Pytal, artonge and szaimen
and removed request for
a teamNovember 13, 2024 16:12
susnux
commented
Nov 18, 2024
ContributorAuthor
/backport to stable30 |
nfebe
approved these changes
Nov 19, 2024
susnuxforce-pushed
the
fix/file-list-filters-reset
branch
from
November 19, 2024 13:53
cb5c499 to
82e6814Comparesusnux
commented
Nov 19, 2024
ContributorAuthor
/compile |
susnuxforce-pushed
the
fix/file-list-filters-reset
branch
4 times, most recently
from
November 20, 2024 18:50
3ff1c10 to
9d80a7eCompare Merged
susnuxforce-pushed
the
fix/file-list-filters-reset
branch
from
January 16, 2025 17:44
9d80a7e to
596be7cComparesusnux
enabled auto-merge
January 16, 2025 17:44
Merged
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/file-list-filters-reset
branch
from
January 21, 2025 15:43
596be7c to
37164c1Compare2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that by design all file list filters are reset on view change.
This is now implemented in the interface rather than manually listening to event by every filter.
Also refactored the filters store to store-setup style as this allows to run an init function.
Checklist