Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix: override iTip Broker to fix several issues - #49268
Merged
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
backportbotBot
requested review from
SebastianKrupinski and st3iny
as code ownersNovember 13, 2024 23:33
| $icalMsg = new VCalendar(); | ||
| foreach ($calendar->select('VTIMEZONE') as $timezone) { | ||
| $icalMsg->add(clone $timezone); |
Check notice
Code scanning / Psalm
MixedClone
| // the attendee was removed and we need to send them a CANCEL message. | ||
| // Also If the meeting STATUS property was changed to CANCELLED | ||
| // we need to send the attendee a CANCEL message. | ||
| if (!$attendee['newInstances'] || $eventInfo['status'] === 'CANCELLED') { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison
| $message->method = $icalMsg->METHOD = 'CANCEL'; | ||
| $message->significantChange = true; | ||
| // clone base event | ||
| $event = clone $eventInfo['instances']['master']; |
Check notice
Code scanning / Psalm
MixedClone
| $oldEventInfo['significantChangeHash'] !== $eventInfo['significantChangeHash']; | ||
| foreach ($attendee['newInstances'] as $instanceId => $instanceInfo) { | ||
| $currentEvent = clone $eventInfo['instances'][$instanceId]; |
Check notice
Code scanning / Psalm
MixedClone
SebastianKrupinski
requested review from
kesselb
and removed request for
miaulalalaNovember 13, 2024 23:39
kesselb
approved these changes
Nov 14, 2024
SebastianKrupinski
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #48583
Requires: #49264