Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix: override iTip Broker to fix several issues - #49269
Conversation
kesselb
commented
Nov 14, 2024
Failing tests look related: https://drone.nextcloud.com/nextcloud/server/57857/9/4
|
SebastianKrupinski
commented
Nov 14, 2024
Yeah, I used a reflection trick to test the protected class, which seems to break with php 8.0. Might need to mod the test with a internal class and forward the request to the parent |
kesselb
commented
Nov 14, 2024
Try invokePrivate from tests/lib/TestCase.php |
d34b3ee to
97c3938CompareSebastianKrupinski
commented
Nov 14, 2024
That worked! Thanks! Wish I knew about that when I created the test originally. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| $icalMsg = new VCalendar(); | ||
| foreach ($calendar->select('VTIMEZONE') as $timezone) { | ||
| $icalMsg->add(clone $timezone); |
Check notice
Code scanning / Psalm
MixedClone
| // the attendee was removed and we need to send them a CANCEL message. | ||
| // Also If the meeting STATUS property was changed to CANCELLED | ||
| // we need to send the attendee a CANCEL message. | ||
| if (!$attendee['newInstances'] || $eventInfo['status'] === 'CANCELLED') { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison
| $message->method = $icalMsg->METHOD = 'CANCEL'; | ||
| $message->significantChange = true; | ||
| // clone base event | ||
| $event = clone $eventInfo['instances']['master']; |
Check notice
Code scanning / Psalm
MixedClone
| $oldEventInfo['significantChangeHash'] !== $eventInfo['significantChangeHash']; | ||
| foreach ($attendee['newInstances'] as $instanceId => $instanceInfo) { | ||
| $currentEvent = clone $eventInfo['instances'][$instanceId]; |
Check notice
Code scanning / Psalm
MixedClone
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
34312d9 to
f62cc42Compare
Backport of #48583
Requires: #49267
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.