Skip to content

feat: add confirmation dialog for file extension changes - #49308

Merged
nfebe merged 2 commits into
masterfrom
feat/46528/ask-confirm-extension-change
Nov 19, 2024
Merged

feat: add confirmation dialog for file extension changes#49308
nfebe merged 2 commits into
masterfrom
feat/46528/ask-confirm-extension-change

Conversation

@nfebe

@nfebenfebe commented Nov 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Introduced a dialog to confirm if users want to proceed with changing the file extension.
  • Added handling for dialog visibility to prevent recursion. (Since it looks like use must press escape to stop rename???)

Resolves : #46528

Screenshot

Screenshot from 2024-11-15 13-14-35

Checklist

  • Tests

@nfebe
nfebe requested review from skjnldsv and susnuxNovember 15, 2024 12:16
@nfebe
nfebeforce-pushed the feat/46528/ask-confirm-extension-change branch from 04da216 to 9502ffdCompareNovember 15, 2024 12:20
skjnldsv
skjnldsv reviewed Nov 15, 2024
View reviewed changes
Comment threadapps/files/src/store/renaming.ts Outdated
skjnldsv
skjnldsv reviewed Nov 15, 2024
View reviewed changes
Comment threadapps/files/src/store/renaming.ts Outdated
marcoambrosini
marcoambrosini reviewed Nov 15, 2024
View reviewed changes

@marcoambrosinimarcoambrosini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would then maybe make the keep action primary instead of the renaming one

Comment threadapps/files/src/store/renaming.ts Outdated
Comment threadapps/files/src/store/renaming.ts Outdated
Comment threadapps/files/src/store/renaming.ts Outdated
@susnux

susnux commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

I would then maybe make the keep action primary instead of the renaming one

It is not destructive (you can revert it) and initialized by the user so as a user I would expect my initiated action to be the primary one.

susnux
susnux reviewed Nov 15, 2024
View reviewed changes
Comment threadapps/files/src/store/renaming.ts
@marcoambrosini

marcoambrosini commented Nov 18, 2024•
edited
Loading

Copy link
Copy Markdown
Member

It is not destructive (you can revert it) and initialized by the user so as a user I would expect my initiated action to be the primary one.

It's not destructive for everyone, but for many users that are not very literate it could still be "sort of" destructive if they don't manage to revert it. So I think we should copy macos in this. People who really know what they're doing will follow through the action anyway.

Screenshot 2024-11-18 at 14 03 07

@nfebe
nfebeforce-pushed the feat/46528/ask-confirm-extension-change branch 2 times, most recently from fe99148 to d706aeeCompareNovember 18, 2024 13:32
nfebe
nfebe commented Nov 18, 2024
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So handled 3 possibilities:

  • Adding file extension
  • Removing file extension
  • Changing file extension

nfebe
nfebe commented Nov 18, 2024
View reviewed changes
Comment threadapps/files/src/store/renaming.ts
@nfebe
nfebeforce-pushed the feat/46528/ask-confirm-extension-change branch from d706aee to a8a934fCompareNovember 18, 2024 16:00
@nfebe
nfebe requested review from skjnldsv and susnuxNovember 19, 2024 10:47
@nfebe
feat: add confirmation dialog for file extension changes
383d98c
- Introduced a dialog to confirm if users want to proceed with changing the file extension.
- Added handling for dialog visibility to prevent recursion. (Since it looks like use must press escape to stop rename???)
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the feat/46528/ask-confirm-extension-change branch from a8a934f to 383d98cCompareNovember 19, 2024 15:49
@nfebe

nfebe commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@nextcloud-command
chore(assets): Recompile assets
724a79a
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
nfebe merged commit af14ff0 into masterNov 19, 2024
@nfebe
nfebe deleted the feat/46528/ask-confirm-extension-change branch November 19, 2024 20:15
@nfebe

nfebe commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@nfebe

nfebe commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@backportbotbackportbotBot mentioned this pull request Nov 19, 2024
Closed
2 tasks
@backportbotbackportbotBot mentioned this pull request Nov 19, 2024
Closed
2 tasks
@susnux

susnux commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

backport to stable29
backport to stable30

We do not backport features, no?

@nfebe

nfebe commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

We do not backport features, no?

I don't know about that but the reason I back-porting this is because it addressing something that is already experienced in previous versions as we have a github ticket reported.

@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 19, 2025
Merged
@AndyScherzingerAndyScherzinger added this to the Nextcloud 31 milestone Mar 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@marcoambrosinimarcoambrosinimarcoambrosini approved these changes
@susnuxsusnuxAwaiting requested review from susnux

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: files🍀 2025-Spring

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

When changing file extension ask for confirmation

6 participants

@nfebe@susnux@marcoambrosini@skjnldsv@AndyScherzinger@nextcloud-command