Uh oh!
There was an error while loading. Please reload this page.
fix(SetupChecks): Pass webfinger if the handler returns 400 too - #49440
Merged
Conversation
joshtrichards
commented
Nov 21, 2024
MemberAuthor
/backport to stable30 |
joshtrichards
commented
Nov 21, 2024
MemberAuthor
/backport to stable29 |
social) is enabledcome-nc
approved these changes
Nov 25, 2024
Merged
AndyScherzinger
commented
Jan 26, 2025
Member
/backport to stable31 |
Signed-off-by: Josh <josh.t.richards@gmail.com>
AndyScherzingerforce-pushed
the
fix-setupcheck-webfinger-400
branch
from
January 26, 2025 12:03
9403728 to
b452dc0Comparesusnux
approved these changes
Jan 26, 2025
susnux
enabled auto-merge
January 26, 2025 13:54
susnux
commented
Jan 26, 2025
Contributor
Cypress unrelated |
AndyScherzinger
disabled auto-merge
January 26, 2025 14:35
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running a check against
/.well-known/webfingerin a stock install the checks are fine, but when an actualwebfingerhandler is installed (like thesocialapp) the return code is going to be 400 per the spec1 since the setup check isn't providing a?resourcevalue (and we're not going to).Semi-related: nextcloud/social#1951 (because we were returning a 500 error since our check doesn't pass a
resourcevalue and now once merged that'll return a 400 as per the spec; though our checks obviously wouldn't have passed either way).TODO
Checklist
Footnotes
https://datatracker.ietf.org/doc/html/rfc7033#section-4.2↩