Skip to content

fix(installer): Label field as username instead of login - #49500

Closed
HB9HIL wants to merge 2 commits into
nextcloud:masterfrom
HB9HIL:installer_login
Closed

fix(installer): Label field as username instead of login#49500
HB9HIL wants to merge 2 commits into
nextcloud:masterfrom
HB9HIL:installer_login

Conversation

@HB9HIL

Copy link
Copy Markdown

Summary

The intended username field in the installer is labeled "Login" which translates in many languages in a different meaning. It's better to label it Username.

Before:

image

After:

image

TODO

Nothing

Checklist

@solracsf

This comment was marked as resolved.

Signed-off-by: HB9HIL <fabian.berg@hb9hil.org>
@HB9HIL

This comment was marked as resolved.

@solracsfsolracsf changed the title Installer - Username field in installer should not labeled "Login"fix(installer): Label field as username instead of loginNov 27, 2024
Comment threadcore/templates/installation.php Outdated
@joshtrichards

Copy link
Copy Markdown
Member

Good catch, @HB9HIL

to match the the other fields in v30
Signed-off-by: Fabian Berg <fabian.berg@hb9hil.org>
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@blizzzblizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzzblizzz mentioned this pull request Jan 29, 2025
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
@susnux

Copy link
Copy Markdown
Contributor

Already implemented in #49962


Thank you very much for your contribution, we hope you submit many more in the future :)

@susnuxsusnux closed this Feb 5, 2025
@AndyScherzingerAndyScherzinger removed this from the Nextcloud 32 milestone Feb 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@HB9HIL@solracsf@joshtrichards@susnux@AndyScherzinger@blizzz