Skip to content

feat(login): add origin check at login - #49560

Merged
sorbaugh merged 2 commits into
masterfrom
fix/login-origin
Dec 20, 2024
Merged

feat(login): add origin check at login#49560
sorbaugh merged 2 commits into
masterfrom
fix/login-origin

Conversation

@Altahrim

@AltahrimAltahrim commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

Summary

Check Origin header on login page

Checklist

@AltahrimAltahrim added 2. developing Work in progress php Pull requests that update Php code labels Nov 29, 2024
@AltahrimAltahrim added this to the Nextcloud 31 milestone Nov 29, 2024
@AltahrimAltahrim self-assigned this Nov 29, 2024
@Altahrim
Altahrimforce-pushed the fix/login-origin branch 4 times, most recently from d695288 to dfaf28eCompareDecember 4, 2024 12:59
artonge added a commit to nextcloud-libraries/nextcloud-e2e-test-server that referenced this pull request Dec 4, 2024
@artonge
feat: Send Origin header in login request
b65ed5f
This is need as the server is now checking that header too: nextcloud/server#49560
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artongeartonge mentioned this pull request Dec 4, 2024
Merged
artonge added a commit to nextcloud-libraries/nextcloud-e2e-test-server that referenced this pull request Dec 4, 2024
@artonge
feat: Send Origin header in login request
201a4a4
This is need as the server is now checking that header too: nextcloud/server#49560
Signed-off-by: Louis Chemineau <louis@chmn.me>
Altahrimand others added 2 commits December 5, 2024 09:51
@Altahrim
feat(login): add origin check at login
22051a7
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@artonge@Altahrim
chore: Bump @nextcloud/cypress to v1.0.0-beta.12
d977265
Signed-off-by: Louis Chemineau <louis@chmn.me>
@AltahrimAltahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2024
@Altahrim
Altahrim marked this pull request as ready for review December 5, 2024 09:10
@Altahrim
Altahrim requested review from a team, ArtificialOwl, provokateurin and yemkareems and removed request for a teamDecember 5, 2024 09:10
skjnldsv
skjnldsv reviewed Dec 11, 2024
View reviewed changes
Comment thread.htaccess
@AltahrimAltahrim added the pending documentation This pull request needs an associated documentation update label Dec 11, 2024
@sorbaugh
sorbaugh merged commit d4715c6 into masterDec 20, 2024
@sorbaugh
sorbaugh deleted the fix/login-origin branch December 20, 2024 13:53
@juliusknorrjuliusknorr mentioned this pull request Dec 23, 2024
Closed
@enjeckenjeck mentioned this pull request Jan 2, 2025
Merged
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
@inet-cologne

inet-cologne commented Feb 15, 2025

Copy link
Copy Markdown

@Altahrim, @skjnldsv, @sorbaugh, @artonge , @canadaduane
Hey guys,
may it be that the change made here in #49560 produces somehow login problems within Nextcloud files app, Nextcloud Talk app and perhaps causing issues with Calendar subscription synchronising?
Since a couple of days after updating (several instances!!) Nextcloud Server to 30.0.5, problems were occurring that Login fails. These could be fixed by deleting and reinstalling and reconfiguring the apps.
30.0.6 does not fix the situation either but now even reinstallation does not help anymore. Login with the above mentioned iOS apps are not possible any more!!
Please see issue #50619!

Thanks for checking that!!
Chris

@inet-cologneinet-cologne mentioned this pull request Feb 15, 2025
Merged
4 tasks
@susnux

susnux commented Feb 23, 2025

Copy link
Copy Markdown
Contributor

@inet-cologne this is not included in Nextcloud 30 but only Nextcloud 31.

@AltahrimAltahrim removed the pending documentation This pull request needs an associated documentation update label Mar 31, 2025
@joshtrichardsjoshtrichards mentioned this pull request May 13, 2025
Closed
8 tasks
@kesselbkesselb mentioned this pull request Jul 1, 2026
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@sorbaughsorbaughsorbaugh approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

3. to reviewWaiting for reviewsphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

6 participants

@Altahrim@inet-cologne@susnux@skjnldsv@sorbaugh@artonge