Uh oh!
There was an error while loading. Please reload this page.
fix(config): drop value details - #49645
Merged
Merged
Conversation
AndyScherzinger
commented
Jan 26, 2025
Member
/backport to stable31 |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
AndyScherzingerforce-pushed
the
fix/noid/clean-config-code
branch
from
January 26, 2025 11:59
c3b684d to
525eb83Compareartonge
approved these changes
Jan 27, 2025
come-nc
approved these changes
Jan 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppConfig,deleteKey()was missing aunset()on array$valueTypes.UserConfig, removing unused arrays as data is now cached in$valueDetails