Skip to content

feat(occ): Better handling of disabled or unreacheable App store - #49697

Merged
Altahrim merged 1 commit into
masterfrom
appStoreDisabledOcc
Jun 11, 2026
Merged

feat(occ): Better handling of disabled or unreacheable App store#49697
Altahrim merged 1 commit into
masterfrom
appStoreDisabledOcc

Conversation

@solracsf

@solracsfsolracsf commented Dec 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Set either appstoreenabled or has_internet_connection to false on config.php file.

Previously in all cases:

# occ app:update previewgenerator
previewgenerator is up-to-date or no updates could be found

After:

# occ app:update previewgenerator
App store access is disabled

or

# occ app:update previewgenerator
Internet connection is disabled, and therefore the default public App store is not reachable

Checklist

@solracsfsolracsf added the 3. to review Waiting for reviews label Dec 6, 2024
@solracsfsolracsf added this to the Nextcloud 31 milestone Dec 6, 2024
@solracsf
solracsf requested review from a team, ArtificialOwl, come-nc, icewind1991, provokateurin and yemkareems and removed request for a teamDecember 16, 2024 14:25
@solracsfsolracsf changed the title feat(occ): Better handling of disabled appstore messagefeat(occ): Better handling of disabled or unreacheable App storeDec 16, 2024
provokateurin
provokateurin reviewed Dec 16, 2024
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add two tests for this?

@blizzzblizzz mentioned this pull request Jan 8, 2025
Merged
This was referenced Jan 14, 2025
Merged
Merged
This was referenced Jan 21, 2025
Merged
Merged
@blizzzblizzz mentioned this pull request Jan 29, 2025
Merged
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
This was referenced Aug 22, 2025
Merged
Merged
Merged
This was referenced Sep 2, 2025
Merged
Merged
This was referenced Jan 9, 2026
Merged
Merged
This was referenced Jan 20, 2026
Merged
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 33, Nextcloud 34Feb 16, 2026
@DorraJaouad
DorraJaouad requested a review from a team as a code ownerApril 23, 2026 09:41
@DorraJaouad
DorraJaouad requested review from CarlSchwan and artonge and removed request for a team and yemkareemsApril 23, 2026 09:41
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsvskjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@susnuxsusnux added the community pull requests from community label Jun 9, 2026
@susnuxsusnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
@solracsf@Altahrim
feat(occ): Better handling of disabled or unreacheable App store
600178d
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@Altahrim
Altahrimforce-pushed the appStoreDisabledOcc branch from bcc9d07 to 600178dCompareJune 11, 2026 08:09
@Altahrim
Altahrim disabled auto-merge June 11, 2026 09:36
@Altahrim
Altahrim merged commit 7269f43 into masterJun 11, 2026
155 of 171 checks passed
@Altahrim
Altahrim deleted the appStoreDisabledOcc branch June 11, 2026 09:36
@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurinprovokateurinprovokateurin left review comments
@AltahrimAltahrimAltahrim approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwanCarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbackport-requestcommunitypull requests from communityfeature: apps managementfeature: occ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@solracsf@Altahrim@provokateurin@come-nc@joshtrichards@susnux@blizzz@skjnldsv@nextcloud-bot