Skip to content

fix(share): Don't print twice the same text on emails - #49746

Merged
skjnldsv merged 1 commit into
masterfrom
printOnlyOnceText
Dec 11, 2024
Merged

fix(share): Don't print twice the same text on emails#49746
skjnldsv merged 1 commit into
masterfrom
printOnlyOnceText

Conversation

@solracsf

@solracsfsolracsf commented Dec 10, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Don't print twice the same text on email.

Also removed those » « From DefaultShare as they are not printed on ShareByMail for consistency.

Before

image

After

image

Checklist

@solracsfsolracsf added this to the Nextcloud 31 milestone Dec 10, 2024
@solracsf
solracsfforce-pushed the printOnlyOnceText branch 2 times, most recently from ef76037 to 0d8e98dCompareDecember 10, 2024 09:16
@solracsf
solracsf marked this pull request as ready for review December 10, 2024 09:54
@solracsf
solracsf requested review from a team, come-nc and skjnldsvDecember 10, 2024 09:54
come-nc
come-nc reviewed Dec 10, 2024
View reviewed changes
Comment threadapps/sharebymail/lib/ShareByMailProvider.php
@solracsfsolracsf changed the title fix(share): Don't print twice the same informationfix(share): Don't print twice the same information on emailsDec 10, 2024
@solracsfsolracsf changed the title fix(share): Don't print twice the same information on emailsfix(share): Don't print twice the same text on emailsDec 10, 2024
come-nc
come-nc reviewed Dec 10, 2024
View reviewed changes
Comment threadlib/private/Share20/DefaultShareProvider.php Outdated
Comment threadapps/sharebymail/lib/ShareByMailProvider.php
@solracsf

solracsf commented Dec 10, 2024

Copy link
Copy Markdown
MemberAuthor

CI seems broken because of #49693 😢

@solracsf@skjnldsv
fix(share): Don't print twice the same information
f86fb0f
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@skjnldsv

skjnldsv commented Dec 10, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Rebased, cypress passes now

@solracsfsolracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 10, 2024
@skjnldsv
skjnldsv merged commit f476265 into masterDec 11, 2024
@skjnldsv
skjnldsv deleted the printOnlyOnceText branch December 11, 2024 07:36
jancborchardt
jancborchardt reviewed Dec 11, 2024
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update! :) I would also suggest to remove the text "Click the button below to open it" as it’s a duplication of the button right below, and just creates more visual noise.

@solracsf in case you also would like to submit a pull request for that as it improves it even more? :)

@solracsfsolracsf mentioned this pull request Dec 13, 2024
Merged
4 tasks
@solracsf

solracsf commented Dec 16, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@solracsf

solracsf commented Dec 16, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@backportbotbackportbotBot mentioned this pull request Dec 16, 2024
Merged
@backportbotbackportbotBot mentioned this pull request Dec 16, 2024
Closed
2 tasks
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt left review comments
@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@come-nccome-ncAwaiting requested review from come-nc

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: emails

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

5 participants

@solracsf@skjnldsv@jancborchardt@artonge@come-nc