fix(oauth): instance name encoding on oauth app in admin by byt3sage · Pull Request #49804 · nextcloud/server

byt3sage · 2024-12-11T19:29:23Z

Resolves: [Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu #39956

Summary

This PR aims to resolve the issue with the encoding of the instance name when shown in the OAuth settings in Nextcloud admin.
This is my first PR for Nextcloud (and hopefully the first of many) so I'm keen for any feedback if this approach doesn't follow what it should.
I've removed instance name from the translate function. My reasoning for this is the instance name will already be in the users own language and this avoids the issue of the translate function escaping special characters.

TODO

Remove instance name binding from the translate function and use string interpolation instead.
Update translation files to ensure the string prior to the instance name is still translated.

Screenshots

Before

After

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

…decoding Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

kesselb · 2024-12-12T18:29:35Z

Thanks for your pull request 👍

Please revert the changes to the language files. The files are synced automatically from Transifex. It's enough to change the source.

byt3sage · 2024-12-13T09:13:06Z

@kesselb Ah that makes sense! I've reverted these back now.

…stance-name-decoding-39956

…yt3sage/server into bug/oauth-instance-name-decoding-39956

…yt3sage/server into bug/oauth-instance-name-decoding-39956 Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…yt3sage/server into bug/oauth-instance-name-decoding-39956

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: grnd-alt <github@belakkaf.net> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…ric one Let the controller access the HintException and show the error to the user. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

byt3sage added 2 commits December 11, 2024 19:22

bug: moved instance name out of l10n to fix issue with instance name …
02a6eb4
…decoding Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: formatting
91a399e
Signed-off-by: byt3sage <jjt@tfmail.co.uk>

byt3sage mentioned this pull request Dec 11, 2024
[Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu #39956
Open
8 tasks

Merge branch 'master' into bug/oauth-instance-name-decoding-39956
5321597

chore: reverted language files
cfafc3c

byt3sageand others added 23 commits December 13, 2024 09:14

Merge branch 'master' of github.com:byt3sage/server into bug/oauth-in…
4c57f0b
…stance-name-decoding-39956

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…
8bfe048
…yt3sage/server into bug/oauth-instance-name-decoding-39956

Merge branch 'master' into bug/oauth-instance-name-decoding-39956
ce6e450

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…
4cd8a48
…yt3sage/server into bug/oauth-instance-name-decoding-39956 Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…
7a9eb28
…yt3sage/server into bug/oauth-instance-name-decoding-39956

chore: formatting
d766b71
Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: reverted language files
f259cbc
Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix: Fix ServiceWorker scope when Nextcloud installed in subfolder
4f8eec1
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets
6ce16a9
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: cleanup leftover debug statement
f4993a6
Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files): throttle favorite with max 5 simultaneous requests
ab6bd5e
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets
7d2508a
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files_sharing): Correct property enforced property names
810a5bc
Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets
1ac6a3a
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Fix(l10n): Update translations from Transifex
f37a39c
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files_sharing): also submit new share on password submit
0f464f8
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets
9687bb8
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(dav): add activity logging for favorites in dav
1690451
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

refactor(tags): move favorite event dispatching to tags.php
9e18dbd
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(tests): remove redundant unit test for activity
0443c66
Signed-off-by: grnd-alt <github@belakkaf.net> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files_sharing): Do not wrap password policy exception into a gene…
931eb36
…ric one Let the controller access the HintException and show the error to the user. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(shares): Wrap exceptions from password validation to set code to 400
a230b74
This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(tests): Adapt ManagerTest to change in Exception class used
fe8c429
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

nextcloud-bot mentioned this pull request Sep 18, 2025
[stable32] 32.0.0 RC3 #55162
Merged

This was referenced Sep 25, 2025
[stable32] 32.0.0 RC4 #55298
Merged
[stable32] 32.0.0 #55354
Merged

skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025

This was referenced Jan 7, 2026
33.0.0 beta 2 #57398
Merged
33.0.0 beta 3 #57441
Merged

This was referenced Jan 14, 2026
33.0.0 beta 4 #57545
Merged
33.0.0 beta 5 #57651
Merged

nextcloud-bot mentioned this pull request Jan 22, 2026
[stable33] 33.0.0 RC1 #57724
Merged

This was referenced Jan 29, 2026
[stable33] 33.0.0 RC2 #57899
Merged
[stable33] 33.0.0 RC3 #58047
Merged

This was referenced Feb 11, 2026
[stable33] 33.0.0 RC4 #58257
Merged
[stable33] 33.0.0 #58364
Merged

blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026

DorraJaouad requested a review from a team as a code owner April 23, 2026 09:41

DorraJaouad requested review from nfebe, sorbaugh and szaimen and removed request for a teamApril 23, 2026 09:41

nextcloud-bot mentioned this pull request May 27, 2026
[stable34] 34.0.0 RC3 #60771
Merged

nextcloud-bot mentioned this pull request Jun 4, 2026
[stable34] 34.0.0rc4 #60979
Closed

skjnldsv mentioned this pull request Jun 4, 2026
[stable34] build(hub): 34.0.0rc4 #60980
Merged

This was referenced Jun 5, 2026
[stable34] 34.0.0 RC5 #61000
Merged
[stable34] 34.0.0 #61060
Merged

nextcloud-bot modified the milestones: Nextcloud 34, Nextcloud 34.0.1 Jun 8, 2026

susnux added the community pull requests from community label Jun 9, 2026

susnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026

Navigation Menu

Uh oh!

Uh oh!

fix(oauth): instance name encoding on oauth app in admin - #49804

fix(oauth): instance name encoding on oauth app in admin#49804
byt3sage wants to merge 46 commits into
nextcloud:masterfrom
byt3sage:bug/oauth-instance-name-decoding-39956

byt3sage commented Dec 11, 2024

Uh oh!

kesselb commented Dec 12, 2024

Uh oh!

byt3sage commented Dec 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Uh oh!

Conversation

byt3sage commented Dec 11, 2024

Summary

TODO

Screenshots

Checklist

Uh oh!

kesselb commented Dec 12, 2024

Uh oh!

byt3sage commented Dec 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants