Skip to content

fix(files_external): wrong type for external mount id - #49843

Merged
Altahrim merged 1 commit into
masterfrom
fix/files_external_scan
Dec 13, 2024
Merged

fix(files_external): wrong type for external mount id#49843
Altahrim merged 1 commit into
masterfrom
fix/files_external_scan

Conversation

@Altahrim

@AltahrimAltahrim commented Dec 13, 2024

Copy link
Copy Markdown
Collaborator

Summary

Fix error:

TypeError: OCA\Files_External\Service\StoragesService::getStorage(): Argument #1 ($id) must be of type int, string given, called in /var/www/html/apps/files_external/lib/Command/StorageAuthBase.php on line 70 and defined in /var/www/html/apps/files_external/lib/Service/StoragesService.php:163

Checklist

@Altahrim
fix(files_external): wrong type for external mount id
12452f7
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@AltahrimAltahrim added bug 3. to review Waiting for reviews php Pull requests that update Php code labels Dec 13, 2024
@AltahrimAltahrim added this to the Nextcloud 31 milestone Dec 13, 2024
@Altahrim
Altahrim requested a review from a teamDecember 13, 2024 09:29
@AltahrimAltahrim self-assigned this Dec 13, 2024
@Altahrim
Altahrim requested review from come-nc, nfebe and skjnldsv and removed request for a teamDecember 13, 2024 09:29
@Altahrim

Altahrim commented Dec 13, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable30

@Altahrim

Altahrim commented Dec 13, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable29

Antreesy
Antreesy approved these changes Dec 13, 2024
View reviewed changes

@AntreesyAntreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks!

@solracsf

solracsf commented Dec 13, 2024

Copy link
Copy Markdown
Member

Tests are broken (no related to this PR). 😿

@Altahrim
Altahrim merged commit 10852d3 into masterDec 13, 2024
@Altahrim
Altahrim deleted the fix/files_external_scan branch December 13, 2024 10:29
This was referenced Dec 13, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsfsolracsfsolracsf approved these changes
@AntreesyAntreesyAntreesy approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

3. to reviewWaiting for reviewsbugphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

3 participants

@Altahrim@solracsf@Antreesy