Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(sharing): send share emails for internal users too - #50217
Merged
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
backportbotBot
requested review from
artonge, miaulalala, nfebe and provokateurinJanuary 16, 2025 17:51
miaulalala
approved these changes
Jan 16, 2025
Antreesy
approved these changes
Jan 16, 2025
provokateurin
enabled auto-merge
January 17, 2025 07:11
nickvergessen
previously requested changes
Jan 17, 2025
nickvergessen
left a comment
Member
There was a problem hiding this comment.
The change is incomplete and breaks Talk integration tests in a non-logical way.
While the response says mail_send = 1, any further request to get the share will say mail_send = 0, so this is very inconsistent.
The problem is that the DefaultShareProvider is not storing the mail_send correctly and not initializing shares it created correctly.
nickvergessen
disabled auto-merge
January 17, 2025 15:37
8 tasks
skjnldsv
enabled auto-merge
February 6, 2025 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #49898