Skip to content

fix(files): support submenu in batch actions header too - #50364

Merged
skjnldsv merged 3 commits into
masterfrom
fix/files-header-submenu
Feb 7, 2025
Merged

fix(files): support submenu in batch actions header too#50364
skjnldsv merged 3 commits into
masterfrom
fix/files-header-submenu

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 23, 2025

Copy link
Copy Markdown
Member

Supersede #45525

image

Summary

  • Add support for subactions on the header
  • Fixed handling of actions and unified some processes between file actions and selection actions
  • Added cypress tests:
    • Standard file actions
    • Nested file actions
    • Selection file actions
    • Nested selection actions

@skjnldsvskjnldsv self-assigned this Jan 23, 2025
@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Jan 23, 2025
@skjnldsv
skjnldsvforce-pushed the fix/files-header-submenu branch 2 times, most recently from 07c66c5 to ed53b64CompareJanuary 24, 2025 13:17
@skjnldsvskjnldsv added this to the Nextcloud 32 milestone Jan 24, 2025
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@skjnldsv
skjnldsvforce-pushed the fix/files-header-submenu branch from 8341866 to 137dbefCompareJanuary 29, 2025 09:22
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/files-header-submenu branch from 137dbef to ca56f7aCompareFebruary 6, 2025 14:29
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile rebase-amend /

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/files-header-submenu branch from 3e85503 to d8df001CompareFebruary 7, 2025 09:07
@skjnldsv
skjnldsv enabled auto-merge February 7, 2025 09:18
@skjnldsv
skjnldsv merged commit f21ffab into masterFeb 7, 2025
@skjnldsv
skjnldsv deleted the fix/files-header-submenu branch February 7, 2025 09:20
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@backportbot

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/50364/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick e10947a5 73e4a13a d8df001f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50364/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/50364/stable31."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@susnux@artonge