Skip to content

Fix example theme - #5061

Merged
MorrisJobke merged 1 commit into
masterfrom
example-theme-guest
Jun 13, 2017
Merged

Fix example theme#5061
MorrisJobke merged 1 commit into
masterfrom
example-theme-guest

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented May 23, 2017

Copy link
Copy Markdown
Member

Otherwise the login page will not be themed. #5036

Move styles.css to server.css

Before:
2017-05-23-111809_943x456_scrot

After:
2017-05-23-111726_951x440_scrot

@codecov

codecovBot commented May 23, 2017

Copy link
Copy Markdown

Codecov Report

Merging #5061 into master will increase coverage by 22.85%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #5061 +/- ##
=============================================
+ Coverage 31.29% 54.14% +22.85% - Complexity 22282 22283 +1 
=============================================
Files 1379 1379 Lines 84747 85337 +590 Branches 1322 1322 =============================================
+ Hits 26520 46209 +19689 + Misses 58227 39128 -19099
Impacted FilesCoverage ΔComplexity Δ
apps/comments/lib/EventHandler.php79.16% <0%> (-8.34%)7% <0%> (ø)
core/js/js.js61.21% <0%> (-0.57%)0% <0%> (ø)
lib/private/Files/Storage/DAV.php64.81% <0%> (+0.21%)161% <0%> (ø)⬇️
lib/private/Files/Stream/Encryption.php75.92% <0%> (+0.46%)53% <0%> (ø)⬇️
lib/private/Installer.php47.14% <0%> (+0.71%)74% <0%> (ø)⬇️
lib/private/Setup.php12.39% <0%> (+0.85%)50% <0%> (ø)⬇️
lib/public/AppFramework/Db/Mapper.php99.12% <0%> (+0.87%)30% <0%> (ø)⬇️
lib/private/legacy/image.php39.06% <0%> (+0.88%)212% <0%> (ø)⬇️
lib/private/Group/Group.php87.96% <0%> (+0.92%)52% <0%> (ø)⬇️
lib/private/Comments/Comment.php96.22% <0%> (+0.94%)55% <0%> (ø)⬇️
... and 365 more

Signed-off-by: Julius Härtl <jus@bitgrid.net>

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@MorrisJobke
MorrisJobke merged commit 262e6fc into masterJun 13, 2017
@MorrisJobke
MorrisJobke deleted the example-theme-guest branch June 13, 2017 22:48
@MorrisJobke

Copy link
Copy Markdown
Member

cc @karlitschek@juliushaertl For the backport

@karlitschek

Copy link
Copy Markdown
Member

nice. please backport 👍

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

backport at #5489

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@MorrisJobke@karlitschek@rullzer