Uh oh!
There was an error while loading. Please reload this page.
fix(sharing): better handle file share attributes - #50642
Merged
Conversation
When a user receives a share with share-permissions but also with download restrictions (hide download or the modern download permission attribute), then re-shares of that share must always also include those restrictions. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
marked this pull request as ready for review
February 4, 2025 14:43
susnuxforce-pushed
the
fix/proper-download-check
branch
from
February 4, 2025 14:43
856f813 to
73dc0f0Comparesusnux
commented
Feb 4, 2025
ContributorAuthor
/backport! to stable29 |
susnux
commented
Feb 4, 2025
ContributorAuthor
/backport! to stable30 |
susnux
commented
Feb 4, 2025
ContributorAuthor
/backport! to stable31 |
2 tasks
This was referenced Feb 4, 2025
skjnldsv
approved these changes
Feb 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proper handling of file share attributes.
Checklist