Uh oh!
There was an error while loading. Please reload this page.
fix(files): properly update store on files conversions success - #50645
Merged
Conversation
skjnldsv
commented
Feb 4, 2025
MemberAuthor
/backport to stable31 |
skjnldsvforce-pushed
the
fix/refresh-convert-list
branch
from
February 4, 2025 15:30
63474d1 to
a5e8e6dComparesusnux
reviewed
Feb 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
susnux
approved these changes
Feb 4, 2025
susnux
left a comment
Contributor
There was a problem hiding this comment.
Just two comments in how to get rid of esline-disable comments ;)
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/refresh-convert-list
branch
from
February 4, 2025 15:41
a5e8e6d to
af405f6Compareskjnldsv
enabled auto-merge
February 4, 2025 15:47
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we make sure to fetch the new files and properly update the store
If none of the files converted are in the current folder the user is looking at, no nodes will be fetched, as it will when they will browse back into said folder again! 💪
Nice performance boost :)