Uh oh!
There was an error while loading. Please reload this page.
enh: Fix display default expire date, add tests & tiny refactors - #50655
Merged
Conversation
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 5, 2025 17:14
97c913b to
e0450eaComparenfebe
commented
Feb 5, 2025
ContributorAuthor
/backport to stable31 |
nfebe
commented
Feb 5, 2025
ContributorAuthor
/backport to stable30 |
nfebe
commented
Feb 5, 2025
ContributorAuthor
/backport to stable29 |
nfebe
marked this pull request as ready for review
February 5, 2025 17:53
nfebe
requested review from
AndyScherzinger, Pytal, artonge, sorbaugh and susnuxFebruary 5, 2025 17:53
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 5, 2025 17:53
e4f5688 to
02c58f8Comparenfebe
commented
Feb 5, 2025
ContributorAuthor
/compile |
susnux
reviewed
Feb 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
reviewed
Feb 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
3 times, most recently
from
February 5, 2025 18:18
dda04e8 to
c83bef6Compareskjnldsv
approved these changes
Feb 5, 2025
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 5, 2025 18:40
c83bef6 to
883819dComparenfebe
commented
Feb 5, 2025
ContributorAuthor
/compile |
susnux
approved these changes
Feb 5, 2025
| $share->setPermissions($permissions); | ||
| } elseif ($shareType === IShare::TYPE_CIRCLE) { | ||
| if (!\OC::$server->getAppManager()->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { | ||
| if (!\OC::$server->get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!\OC::$server->get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { | |
| if (!\OCP\Server::get(IAppManager::class)->isEnabledForUser('circles') || !class_exists('\OCA\Circles\ShareByCircleProvider')) { |
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 5, 2025 19:22
d5594b0 to
ea9c3abComparemarcoambrosini
approved these changes
Feb 6, 2025
artonge
approved these changes
Feb 6, 2025
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 6, 2025 09:59
ea9c3ab to
d9b250aComparenfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 6, 2025 10:19
d9b250a to
fb207eaCompareSigned-off-by: nfebe <fenn25.fn@gmail.com>
Since `ShareEntryLink` component is used to both create and display/list the share links, we should only set default expiration date on `share.expireDate` when we know is a new share. Otherwise, we overidding data from the backend. Signed-off-by: nfebe <fenn25.fn@gmail.com>
…reate share Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
…nput Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebeforce-pushed
the
fix/share-sidebar-bugs
branch
from
February 6, 2025 11:15
fb207ea to
a544252Comparenfebe
enabled auto-merge
February 6, 2025 12:40
This was referenced Feb 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves : #50495
Screencasts
Show default expiration date before create share
show-default-date.mp4
Quick share select updated without refresh
quick-share.mp4
Checklist