Skip to content

fix: make sure we process mime extensions as string - #50660

Merged
skjnldsv merged 2 commits into
masterfrom
fix/mime-int
Feb 6, 2025
Merged

fix: make sure we process mime extensions as string#50660
skjnldsv merged 2 commits into
masterfrom
fix/mime-int

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Feb 5, 2025

Copy link
Copy Markdown
Member

Fix#42902

  • Fix extension handling
  • Added phpunit tests

@skjnldsvskjnldsv added this to the Nextcloud 32 milestone Feb 5, 2025
@skjnldsv
skjnldsv requested review from a team, kesselb and tcitworldFebruary 5, 2025 10:52
@skjnldsvskjnldsv self-assigned this Feb 5, 2025
@skjnldsv
skjnldsv requested review from Altahrim, come-nc and icewind1991 and removed request for a teamFebruary 5, 2025 10:52
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@AndyScherzingerAndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

Comment threadlib/public/Files/IMimeTypeDetector.php Outdated
Comment threadlib/private/Files/Type/Detection.php Outdated
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadlib/public/Files/IMimeTypeLoader.php Outdated
Comment threadlib/private/Files/Type/Detection.php Outdated
Comment threadlib/private/Files/Type/Detection.php Outdated
susnux
susnux previously requested changes Feb 5, 2025

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type of interface and implementation does not match

Comment threadlib/public/Files/IMimeTypeDetector.php Outdated
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit 93c72f5 into masterFeb 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to set .0 through .9 as mimetypemapping.json

5 participants

@skjnldsv@AndyScherzinger@susnux@tcitworld@kesselb