Uh oh!
There was an error while loading. Please reload this page.
fix(files): only send config update requests if user is logged in - #50680
Merged
Conversation
susnux
requested review from
a team, Pytal, artonge and nfebe
and removed request for
a teamFebruary 6, 2025 09:21
susnux
marked this pull request as ready for review
February 6, 2025 09:21
susnux
commented
Feb 6, 2025
ContributorAuthor
/backport to stable31 |
artonge
approved these changes
Feb 6, 2025
Pytal
approved these changes
Feb 6, 2025
skjnldsv
approved these changes
Feb 6, 2025
susnuxforce-pushed
the
fix/files-public-share
branch
from
February 6, 2025 20:49
6f92823 to
c6948ebComparesusnux
commented
Feb 6, 2025
ContributorAuthor
/compile |
skjnldsvforce-pushed
the
fix/files-public-share
branch
from
February 7, 2025 10:06
959fad8 to
22e2454Compareskjnldsv
commented
Feb 7, 2025
Member
/compile amend / |
skjnldsv
commented
Feb 7, 2025
Member
Rebased |
nextcloud-commandforce-pushed
the
fix/files-public-share
branch
from
February 7, 2025 10:10
22e2454 to
336ab6aCompareskjnldsv
approved these changes
Feb 7, 2025
skjnldsv
previously requested changes
Feb 7, 2025
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Cypress failure is related. 500 error on sorting user config change
susnux
commented
Feb 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
susnuxforce-pushed
the
fix/files-public-share
branch
from
February 7, 2025 13:25
b0c9b1e to
409cb14Comparesusnux
commented
Feb 7, 2025
ContributorAuthor
Yep |
skjnldsv
approved these changes
Feb 7, 2025
susnux
commented
Feb 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
Since we use the files app also for public shares it is not guaranteed that there is a user logged in, in that case the update for user / view config will fail. So ensure there is a user or do not send a request. Also refactor both stores to setup styles to fix (remove) initialization hack, which causes Typescript issues. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/files-public-share
branch
from
February 8, 2025 13:31
a538002 to
48bf91aCompare2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since we use the files app also for public shares it is not guaranteed that there is a user logged in, in that case the update for user / view config will fail.
So ensure there is a user or do not send a request.
Also refactor both stores to setup styles to fix (remove) initialization hack, which causes Typescript issues.
TODO
Checklist