Skip to content

[stable29] chore : Comprehensive e2e testing for public sharing - #50696

Merged
Altahrim merged 4 commits into
stable29from
backport/50626/stable29
Feb 11, 2025
Merged

[stable29] chore : Comprehensive e2e testing for public sharing#50696
Altahrim merged 4 commits into
stable29from
backport/50626/stable29

Conversation

@backportbot

@backportbotbackportbotBot commented Feb 6, 2025

Copy link
Copy Markdown

Backport of #50626

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbotBot requested review from artonge and nfebeFebruary 6, 2025 13:37
@backportbotbackportbotBot added enhancement 3. to review Waiting for reviews labels Feb 6, 2025
@backportbotbackportbotBot added this to the Nextcloud 29.0.12 milestone Feb 6, 2025
@nfebe
nfebeforce-pushed the backport/50626/stable29 branch from 17dfa40 to 915de27CompareFebruary 6, 2025 13:40
@nfebenfebe changed the title [stable29] [stable30] chore : Comprehensive e2e testing for public sharing[stable29] chore : Comprehensive e2e testing for public sharingFeb 6, 2025
@nfebe

nfebe commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

/compile

@nfebe
nfebe marked this pull request as ready for review February 6, 2025 14:09
@nfebe
nfebe requested review from Pytal and susnuxFebruary 6, 2025 14:09
@AltahrimAltahrim mentioned this pull request Feb 11, 2025
6 tasks
@susnux
susnuxforce-pushed the backport/50626/stable29 branch from e9a9d46 to f94a149CompareFebruary 11, 2025 16:05
nfebeand others added 4 commits February 11, 2025 17:16
This addition enhances the testing framework for public sharing by
improving the setup and management of share contexts.
Additionally, the update optimizes share permission adjustments and
improves state management, making public share setups more efficient and maintainable.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations:
- Password and expiration date enforced
- Password enforced with a default expiration date
- Expiration date enforced with optional password
- Default password and expiration date without enforcement
- Password enforced, expiration date set but not enforced
- Both password and expiration date not enforced, but defaults set
- Password not enforced, expiration date enforced
- Password not enforced, default expiration date set
- Password and expiration date not enforced with no defaults
The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the backport/50626/stable29 branch from f94a149 to df5ffb1CompareFebruary 11, 2025 16:17
@Altahrim
Altahrim merged commit ef2226a into stable29Feb 11, 2025
@Altahrim
Altahrim deleted the backport/50626/stable29 branch February 11, 2025 17:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nfebe@artonge@skjnldsv@Altahrim@nextcloud-command