Skip to content

feat(admin_audit): write admin audit log for AnyLoginFailedEvent - #50697

Merged
nickvergessen merged 1 commit into
masterfrom
admin-audit-listen-failed-login
Feb 6, 2025
Merged

feat(admin_audit): write admin audit log for AnyLoginFailedEvent#50697
nickvergessen merged 1 commit into
masterfrom
admin-audit-listen-failed-login

Conversation

@luka-nextcloud

Copy link
Copy Markdown
Contributor

Summary

Write admin audit log for AnyLoginFailedEvent.

Checklist

Comment threadlib/public/Authentication/Events/AnyLoginFailedEvent.php
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@nickvergessen
nickvergessen requested review from blizzz and removed request for rullzerFebruary 6, 2025 15:30

@joshtrichardsjoshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but did not test.

@joshtrichardsjoshtrichards added this to the Nextcloud 32 milestone Feb 6, 2025
@nickvergessen
nickvergessen merged commit 1211c03 into masterFeb 6, 2025
@nickvergessen
nickvergessen deleted the admin-audit-listen-failed-login branch February 6, 2025 18:13
@luka-nextcloudluka-nextcloud removed the 3. to review Waiting for reviews label Feb 6, 2025
@luka-nextcloud

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@luka-nextcloud

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@luka-nextcloud

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@backportbot

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50697/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 5750d2af
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50697/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

Copy link
Copy Markdown

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/50697/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 5750d2af
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50697/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@luka-nextcloud

Copy link
Copy Markdown
ContributorAuthor

Backport to 29 & 30 failed, this file - AuthEventListener.php doesn't exist...

@joshtrichards

Copy link
Copy Markdown
Member

To backport you'd have to go back in time to before #47865 and do manual legacy implementation. Not terribly hard, but not sure I'd bother...

@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsvskjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: Login failed event missing from admin audit log

4 participants

@luka-nextcloud@joshtrichards@nickvergessen@skjnldsv