Fixed a crash caused by Local::copyFromStorage() not conforming to Co…

[mjmunger]

Fix#5071
Local::copyFromStorage was not adhering to Common::copyFromStorage or an interface that governs the two of them. Added the parameter to make it conform.

[mention-bot]

@mjmunger, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @LukasReschke to be potential reviewers.

[icewind1991]

Makes sense

[mjmunger]

Not sure if you need anything else from me?

[nickvergessen]

@mjmunger can you fix lib/private/Lockdown/Filesystem/NullStorage.php as well?

Other then that it looks good.

[MorrisJobke]

let's get this in and fix the NullStorage separately.

[mjmunger]

Same issue with lib/private/Lockdown/Filesystem/NullStorage.php? Or something different?

[MorrisJobke]

Same issue with lib/private/Lockdown/Filesystem/NullStorage.php? Or something different?

Yes, it seems so - do you create a PR to fix this as well or should I?

[MorrisJobke]

Backport of this is in #5397

[mjmunger]

Create a PR and assign to me. Im not at a computer ATM.

[mjmunger]

Apparently, I'm drunk. You can't assign a pull request. Please create it. I'm not at a computer.

[MorrisJobke]

@mjmunger can you fix lib/private/Lockdown/Filesystem/NullStorage.php as well?

Just checked and the NullStorage doesn't seem to need it. So will keep it as it is. Thanks anyway @mjmunger