Uh oh!
There was an error while loading. Please reload this page.
add new config switched for the global scale architecture - #5084
Conversation
mention-bot
commented
May 24, 2017
@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @j-ed and @LukasReschke to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@## master #5084 +/- ##
=============================================
- Coverage 54.15% 31.29% -22.86% - Complexity 22286 22293 +7
=============================================
Files 1379 1380 +1 Lines 85338 84780 -558 Branches 1322 1322 =============================================
- Hits 46214 26532 -19682 - Misses 39124 58248 +19124
|
d81d694 to
5a5b7abCompareschiessle
commented
May 26, 2017
@MorrisJobke@oparoz please test and review if this matches your expectation regarding the personal page and the admin settings. |
51e79f1 to
c685b6fCompareMorrisJobke
commented
May 29, 2017
Earliest in 1 week, but what you described sounded good. |
I have a strange issue when switching to your branch: Downgrading is not supported and is likely to cause unpredictable issues (from 13.0.0.0 to 12.0.0.28) |
c685b6f to
337262bCompareSigned-off-by: Bjoern Schiessle <bjoern@schiessle.org>
337262b to
7c2d473Compareschiessle
commented
May 29, 2017
Tests passed... ready for final review 😃 |
schiessle
commented
Jun 2, 2017
since @daita told me that he tested it successfully I will count this as the second positive review and merge it... |
blizzz
commented
Jun 2, 2017
One thing that should be documented, otherwise its confusing for admins:
|
MorrisJobke
commented
Jun 6, 2017
@schiessle when I set following: What else happens beside that the input fields on the personal page are gone? |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Introduce two config switches:
gs.enabled, default is false, if it is set to true the server runs in a global scale setupRationals:
cc @MorrisJobke@oparoz