Uh oh!
There was an error while loading. Please reload this page.
fix(dav): Create SAB at installation - #51144
Merged
Merged
Conversation
ChristophWurst
requested review from
SebastianKrupinski and hamza221
as code ownersFebruary 28, 2025 16:33
ChristophWurst
commented
Feb 28, 2025
MemberAuthor
/backport to stable31 |
ChristophWurst
commented
Feb 28, 2025
MemberAuthor
/backport to stable30 |
ChristophWurst
commented
Feb 28, 2025
MemberAuthor
/backport to stable29 |
SebastianKrupinski
approved these changes
Feb 28, 2025
kesselb
reviewed
Mar 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ChristophWurstforce-pushed
the
fix/dav/create-sab-install
branch
from
March 3, 2025 11:34
0dc9390 to
2528e70CompareChristophWurst
enabled auto-merge
March 3, 2025 11:34
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
kesselbforce-pushed
the
fix/dav/create-sab-install
branch
from
March 6, 2025 17:40
2528e70 to
ec664b0Comparekesselb
requested review from
icewind1991, provokateurin and yemkareems
and removed request for
a teamMarch 6, 2025 17:40
provokateurin
approved these changes
Mar 7, 2025
This was referenced Mar 7, 2025
This was referenced Mar 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SAB is created on demand. Weirdly enough this only happens for the second user of an instance, and in high concurrent setups there can be a race for the creation of the AB.
This moves the creation to an install repair step that is run once at installation time.
This change was tested with nextcloud/mail#10707. Recently Mail integration tests failed when the SAB didn't exist and tests created it while being in a transaction.
TODO
Checklist