Uh oh!
There was an error while loading. Please reload this page.
fix(settings): Fix infinitely loading account management page with pagination of groups - #51336
Merged
Conversation
Pytalforce-pushed
the
perf/paginate-filter-groups
branch
2 times, most recently
from
March 18, 2025 22:19
93936f1 to
bc2d292ComparePytal
marked this pull request as ready for review
March 18, 2025 22:26
Pytal
requested review from
Altahrim, nfebe, susnux, szaimen and yemkareems
and removed request for
a teamMarch 18, 2025 22:26
szaimen
removed their request for review
March 19, 2025 01:38
come-nc
reviewed
Mar 20, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
perf/paginate-filter-groups
branch
from
March 28, 2025 21:17
4a01a06 to
1d0ae0cComparePytal
commented
Mar 28, 2025
MemberAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Pytal
commented
Mar 28, 2025
MemberAuthor
/backport to stable31 |
Pytal
commented
Mar 28, 2025
MemberAuthor
/backport to stable30 |
2 tasks
2 tasks
come-nc
commented
Apr 1, 2025
Contributor
/backport to stable30 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
8 tasks
solracsf
commented
May 23, 2025
Member
This PR is causing issues in groups display names: #52130 |
provokateurin
commented
May 23, 2025
Member
@solracsf please do it the other way around and mention the PR in the issue and avoid bumping merged PRs. |
8 tasks
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a large number of groups, e.g. >=10,000, the compute load on the server and client becomes excessive. On the server all groups are pre-computed in-memory resulting in increased response latency and excessive payload size. As a result the page loads indefinitely and becomes unresponsive.
To Do
Checklist