Skip to content

fix(AppDiscover): Strip double-quotes from folder name - #51379

Merged
solracsf merged 1 commit into
masterfrom
appStoreCacheFolder
Mar 11, 2025
Merged

fix(AppDiscover): Strip double-quotes from folder name#51379
solracsf merged 1 commit into
masterfrom
appStoreCacheFolder

Conversation

@solracsf

Copy link
Copy Markdown
Member

Checklist

@solracsfsolracsf added the 2. developing Work in progress label Mar 10, 2025
@solracsfsolracsf added this to the Nextcloud 32 milestone Mar 10, 2025
@solracsfsolracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2025
@solracsf
solracsf marked this pull request as ready for review March 10, 2025 17:28
@solracsf
solracsf requested a review from a team as a code ownerMarch 10, 2025 17:28
@solracsf
solracsf requested review from ArtificialOwl, artonge and sorbaugh and removed request for a teamMarch 10, 2025 17:28
@solracsf

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@solracsf

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@kesselb

This comment was marked as outdated.

@kesselb
kesselb requested a review from susnuxMarch 10, 2025 17:49
@kesselbkesselb added the bug label Mar 10, 2025
Comment threadlib/private/App/AppStore/Fetcher/AppDiscoverFetcher.php Outdated
susnux

This comment was marked as outdated.

@susnux
susnux dismissed their stale reviewMarch 10, 2025 17:54

Too quickly

@susnux

This comment was marked as outdated.

@susnux
susnux self-requested a review March 10, 2025 17:55
@solracsf

solracsf commented Mar 10, 2025

Copy link
Copy Markdown
MemberAuthor

EDIT: Applied the fix to the folder creation logic.

@solracsf
solracsfforce-pushed the appStoreCacheFolder branch from e364d09 to 124985cCompareMarch 10, 2025 18:06
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf
solracsfforce-pushed the appStoreCacheFolder branch from 124985c to 659747eCompareMarch 10, 2025 18:11
@solracsf
solracsf requested a review from kesselbMarch 10, 2025 18:12
@solracsfsolracsf changed the title fix(AppDiscover): Ensure created cache folder is safe-chars onlyfix(AppDiscover): Strip double-quotes from folder nameMar 11, 2025
@solracsf
solracsf enabled auto-merge March 11, 2025 16:47

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? ;) I find getEtag and etag a bit weird.

Comment on lines +134 to +135
$getEtag = $this->discoverFetcher->getETag() ?? date('Y-m');
$etag = trim($getEtag, '"');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$getEtag = $this->discoverFetcher->getETag() ?? date('Y-m');
$etag = trim($getEtag, '"');
$etag = $this->discoverFetcher->getETag() ?? date('Y-m');
$cacheFolderName = trim($getEtag, '"');

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Remote images in discover section in AppStore not loading if Windows filename compatibility is enabled

4 participants

@solracsf@kesselb@susnux@skjnldsv