Skip to content

fix(cardav): only show users from enabled addressBooks in contacts menu - #51380

Merged
hamza221 merged 1 commit into
masterfrom
fix/noid/contactsmenu-ab-enabled
Mar 17, 2025
Merged

fix(cardav): only show users from enabled addressBooks in contacts menu#51380
hamza221 merged 1 commit into
masterfrom
fix/noid/contactsmenu-ab-enabled

Conversation

@hamza221

@hamza221hamza221 commented Mar 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Only show contacts from Enabled address Books in contact menu

TODO

  • Fix tests

Checklist

@hamza221hamza221 added bug 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Mar 10, 2025
@hamza221hamza221 self-assigned this Mar 10, 2025
@hamza221
hamza221 requested review from a team and SebastianKrupinski as code ownersMarch 10, 2025 19:40
@hamza221
hamza221 requested review from come-nc, nfebe and provokateurin and removed request for a teamMarch 10, 2025 19:40
@hamza221hamza221 changed the title fix(cardav): only show useres from enabled addressBooks in contacts menufix(cardav): only show users from enabled addressBooks in contacts menuMar 10, 2025
come-nc
come-nc previously requested changes Mar 11, 2025
View reviewed changes
Comment threadapps/dav/lib/AppInfo/Application.php Outdated
Comment threadapps/dav/lib/CardDAV/AddressBookImpl.php Outdated
Comment threadlib/public/IAddressBook.php Outdated
@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Mar 11, 2025
ChristophWurst
ChristophWurst approved these changes Mar 11, 2025
View reviewed changes
Comment threadlib/public/IAddressBook.php Outdated
Comment threadapps/dav/lib/CardDAV/AddressBookImpl.php Outdated
@SebastianKrupinski

SebastianKrupinski commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Tested. Works!

@hamza221
hamza221 requested a review from come-ncMarch 13, 2025 12:13
@hamza221

hamza221 commented Mar 13, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

ChristophWurst
ChristophWurst reviewed Mar 13, 2025
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS

Comment threadlib/public/IHandleAddressBook.php
Comment threadlib/public/IHandleAddressBook.php Outdated
Comment threadlib/public/IHandleAddressBook.php Outdated
Comment threadlib/public/IHandleAddressBook.php Outdated
@hamza221

hamza221 commented Mar 13, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@hamza221

hamza221 commented Mar 13, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

ChristophWurst
ChristophWurst reviewed Mar 13, 2025
View reviewed changes
Comment threadlib/public/IHandleAddressBook.php Outdated
@hamza221
hamza221force-pushed the fix/noid/contactsmenu-ab-enabled branch 2 times, most recently from 32f8e91 to 53e2eb9CompareMarch 14, 2025 09:58
@hamza221hamza221 mentioned this pull request Mar 14, 2025
Merged
@hamza221hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2025
@hamza221hamza221 added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 14, 2025
ChristophWurst
ChristophWurst requested changes Mar 17, 2025
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/server/pull/51380/files#r1998480122 marked as resolved but is not resolved

@hamza221
fix(cardav): only show useres from enabled addressBooks in contacts menu
c9d9abd
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221
hamza221force-pushed the fix/noid/contactsmenu-ab-enabled branch from 53e2eb9 to c9d9abdCompareMarch 17, 2025 10:56
@hamza221
hamza221 merged commit bf06b25 into masterMar 17, 2025
@hamza221
hamza221 deleted the fix/noid/contactsmenu-ab-enabled branch March 17, 2025 16:51
This was referenced Mar 17, 2025
Merged
Merged
Merged
@artongeartonge mentioned this pull request Mar 19, 2025
Merged
@hamza221hamza221 mentioned this pull request Aug 18, 2025
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@GretaDGretaDGretaD approved these changes
@kesselbkesselbAwaiting requested review from kesselb
@SebastianKrupinskiSebastianKrupinskiAwaiting requested review from SebastianKrupinskiSebastianKrupinski is a code owner
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nc

Assignees

@hamza221hamza221

Labels

3. to reviewWaiting for reviewsbugfeature: carddavRelated to CardDAV internalspending documentationThis pull request needs an associated documentation update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hamza221@SebastianKrupinski@ChristophWurst@GretaD@come-nc@tobiasKaminsky