Skip to content

feat(bulk-upload): change the default to disabled as there are still some bugs present - #51431

Merged
tobiasKaminsky merged 1 commit into
masterfrom
enh/noid/disable-bulk-upload
Apr 11, 2025
Merged

feat(bulk-upload): change the default to disabled as there are still some bugs present#51431
tobiasKaminsky merged 1 commit into
masterfrom
enh/noid/disable-bulk-upload

Conversation

@szaimen

@szaimenszaimen commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

@szaimenszaimen added bug 3. to review Waiting for reviews labels Mar 12, 2025
@szaimenszaimen added this to the Nextcloud 32 milestone Mar 12, 2025
@szaimen
szaimen requested a review from a team as a code ownerMarch 12, 2025 11:17
@szaimen
szaimen requested review from ArtificialOwl, artonge and come-nc and removed request for a teamMarch 12, 2025 11:17
@szaimen

szaimen commented Mar 12, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@szaimen

szaimen commented Mar 12, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@szaimen

szaimen commented Mar 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Setting to draft for now as discussed with @Rello

@szaimen
szaimen marked this pull request as draft March 12, 2025 11:21
@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 12, 2025
@provokateurin

provokateurin commented Mar 12, 2025

Copy link
Copy Markdown
Member

Hm it seems it's the client that is broken and not the server, so it should be disabled in the client instead?

@szaimen

szaimen commented Apr 10, 2025

Copy link
Copy Markdown
ContributorAuthor

Hm it seems it's the client that is broken and not the server, so it should be disabled in the client instead?

I just discussed this with @Rello and It will disabled in the future in the desktop client. However to also cover outdated clients, it is necessary to disable it here as well.

@szaimen
szaimen marked this pull request as ready for review April 10, 2025 13:28
@szaimen
feat(bulk-upload): change the default to disabled as there are still …
5e6478f
…some bugs present
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen
szaimenforce-pushed the enh/noid/disable-bulk-upload branch from 92022d5 to 5e6478fCompareApril 10, 2025 13:28
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 10, 2025
@szaimen

szaimen commented Apr 10, 2025

Copy link
Copy Markdown
ContributorAuthor

So ready for review!

provokateurin
provokateurin approved these changes Apr 10, 2025
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️

@tobiasKaminsky
tobiasKaminsky merged commit 5e9ebe4 into masterApr 11, 2025
@tobiasKaminsky
tobiasKaminsky deleted the enh/noid/disable-bulk-upload branch April 11, 2025 09:22
This was referenced Apr 11, 2025
Merged
Merged
@artonge

artonge commented Apr 11, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

I don't get why this is merged. The desktop client has a much more flexible release schedule, and I would assume that clients get upgraded much sooner than servers. Also, it would have been better to change the capability name instead of disabling it altogether, this would have allowed futur desktop client versions improve their logic. We now have arbitrary server versions for which it does not work for no reason.

@artongeartonge mentioned this pull request Apr 11, 2025
Merged
@provokateurin

provokateurin commented Apr 11, 2025

Copy link
Copy Markdown
Member

I agree with @artonge, like I said before already.

@susnuxsusnux added the pending documentation This pull request needs an associated documentation update label Apr 14, 2025
@joshtrichardsjoshtrichards added the hotspot: file transfer performance upload & download performance related optimizations label Apr 16, 2025
@szaimenszaimen removed the pending documentation This pull request needs an associated documentation update label Apr 18, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@RelloRelloRello approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend
@AndyScherzingerAndyScherzingerAwaiting requested review from AndyScherzinger
@sorbaughsorbaughAwaiting requested review from sorbaugh

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbughotspot: file transfer performanceupload & download performance related optimizations

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

9 participants

@szaimen@provokateurin@artonge@nickvergessen@Rello@joshtrichards@susnux@tobiasKaminsky@skjnldsv