Skip to content

[stable29] fix(files_sharing): ensure share status action works also in grid view - #51557

Merged
susnux merged 3 commits into
stable29from
fix/backport-gridview-29
Mar 31, 2025
Merged

[stable29] fix(files_sharing): ensure share status action works also in grid view#51557
susnux merged 3 commits into
stable29from
fix/backport-gridview-29

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Manual backport of #51469

@susnuxsusnux added bug 3. to review Waiting for reviews labels Mar 18, 2025
@susnuxsusnux added this to the Nextcloud 29.0.14 milestone Mar 18, 2025
@susnux
susnux requested a review from a teamMarch 18, 2025 10:13
@susnux
susnux requested a review from skjnldsv as a code ownerMarch 18, 2025 10:13
@susnux
susnux requested review from artonge, skjnldsv and sorbaugh and removed request for a teamMarch 18, 2025 10:13
@susnuxsusnux changed the title Fix/backport gridview 29[stable29] fix(files_sharing): ensure share status action works also in grid viewMar 18, 2025
@AltahrimAltahrim mentioned this pull request Mar 18, 2025
28 tasks
@susnux
susnuxforce-pushed the fix/backport-gridview-29 branch from f8daf00 to 3aa9ee8CompareMarch 18, 2025 11:19
@susnux

Copy link
Copy Markdown
ContributorAuthor

/compile amend/

@blizzzblizzz mentioned this pull request Mar 19, 2025
@AndyScherzinger
AndyScherzingerforce-pushed the fix/backport-gridview-29 branch 4 times, most recently from 7c355d5 to 823a6f8CompareMarch 26, 2025 09:11
@AndyScherzinger

Copy link
Copy Markdown
Member

/compile /

@AndyScherzinger
AndyScherzingerforce-pushed the fix/backport-gridview-29 branch 5 times, most recently from 175faf5 to ac57d13CompareMarch 30, 2025 16:48
@AndyScherzinger

Copy link
Copy Markdown
Member

Remove some hacks from files app about the *files_sharing* status
action, in general not sure why this hack was there instead of being in
the correct app - but it broke the grid view.
So now the sharing information is also available in grid view.
Moreover the icon is fixed in size to not overflow the actions menu.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/backport-gridview-29 branch from ac57d13 to 7231905CompareMarch 31, 2025 16:51
@susnux
susnux merged commit 142be78 into stable29Mar 31, 2025
@susnux
susnux deleted the fix/backport-gridview-29 branch March 31, 2025 18:13
@AndyScherzinger

Copy link
Copy Markdown
Member

🎉 MERCI

@AltahrimAltahrim mentioned this pull request Apr 3, 2025
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@AndyScherzinger@artonge@skjnldsv@blizzz