Skip to content

[stable29] fix: pass hide download attribute while creating the share to fix github issue 50788 - #51580

Merged
susnux merged 5 commits into
stable29from
backport/51250/stable29
Apr 2, 2025
Merged

[stable29] fix: pass hide download attribute while creating the share to fix github issue 50788#51580
susnux merged 5 commits into
stable29from
backport/51250/stable29

Conversation

@backportbot

@backportbotbackportbotBot commented Mar 19, 2025

Copy link
Copy Markdown

Backport of #51250

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@yemkareems

Copy link
Copy Markdown
Contributor

/compile

@github-actions

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
7 queries added
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 7 queries added
- UPDATE "oc_filecache" SET "size" = :dcValue3 WHERE ("fileid" = :dcValue1) AND (("size" <> :dcValue2) OR ("size" IS NULL))
- UPDATE "oc_filecache" SET "size" = :dcValue3 WHERE ("fileid" = :dcValue1) AND (("size" <> :dcValue2) OR ("size" IS NULL))
- SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
- SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
+ SELECT "storage", "path", "mimetype" FROM "oc_filecache" WHERE "fileid" = :dcValue1
+ SELECT "storage_id", "root_id", "user_id", "mount_point", "mount_id", "f"."path", "mount_provider_class" FROM "oc_mounts" "m" INNER JOIN "oc_filecache" "f" ON "m"."root_id" = "f"."fileid" WHERE ("storage_id" = ?) AND ("user_id" = ?)
+ SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE "filecache"."fileid" = :dcValue1
+ DELETE FROM "oc_filecache" WHERE "fileid" = :dcValue1
+ DELETE FROM "oc_filecache_extended" WHERE "fileid" = :dcValue1
+ DELETE FROM "oc_files_metadata" WHERE "file_id" = :dcValue1
+ DELETE FROM "oc_files_metadata_index" WHERE "file_id" = :dcValue1
+ SELECT "json", "sync_token" FROM "oc_files_metadata" WHERE "file_id" = :dcValue1
+ SELECT "fileid" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("path_hash" = :dcValue2)
+ UPDATE "oc_file_locks" SET "lock" = :dcValue1, "ttl" = :dcValue2 WHERE ("key" = :dcValue3) AND ("lock" = :dcValue4)
+ SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE ("storage" = :dcValue1) AND ("path_hash" = :dcValue2)

yemkareemsand others added 4 commits April 2, 2025 13:15
…hub issue 50788
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the backport/51250/stable29 branch from d4ab000 to e1f94d0CompareApril 2, 2025 11:16
@susnux
susnux marked this pull request as ready for review April 2, 2025 11:16
@susnux

Copy link
Copy Markdown
Contributor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit abcf1e4 into stable29Apr 2, 2025
@susnux
susnux deleted the backport/51250/stable29 branch April 2, 2025 12:37
@AltahrimAltahrim mentioned this pull request Apr 3, 2025
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@yemkareems@susnux@nfebe@blizzz@nextcloud-command