Skip to content

Add command to list orphan objects - #51603

Merged
icewind1991 merged 5 commits into
masterfrom
object-store-orphan
Mar 31, 2025
Merged

Add command to list orphan objects#51603
icewind1991 merged 5 commits into
masterfrom
object-store-orphan

Conversation

@icewind1991

@icewind1991icewind1991 commented Mar 20, 2025

Copy link
Copy Markdown
Member

Adds the following commands:

  • occ files:object:info <object id> get metadata from an object
  • occ files:object:list list all objects
  • occ files:object:orphans list all objects not referenced in the database

Only implemented for S3 at the moment

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Mar 20, 2025
@icewind1991icewind1991 added this to the Nextcloud 32 milestone Mar 20, 2025
@szaimen
szaimen removed their request for review March 20, 2025 15:44
@icewind1991
icewind1991force-pushed the object-store-orphan branch 2 times, most recently from c3ed005 to 18e9980CompareMarch 20, 2025 15:53
@icewind1991icewind1991 mentioned this pull request Mar 20, 2025
Closed
come-nc
come-nc reviewed Mar 24, 2025
View reviewed changes
Comment threadapps/files/lib/Command/Object/Info.php Outdated
Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
use Symfony\Component\Console\Output\OutputInterface;

class ObjectUtil {
class ObjectUtil extends Base {

@come-nccome-ncMar 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that needed?
It’s really weird for this helper that’s not a command or a command parent to extend Base.

@icewind1991icewind1991Mar 25, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to get access to the output helpers

@come-nccome-ncMar 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don’t like it. It should either be a parent class to the commands, or a trait that they use.

@icewind1991icewind1991Mar 28, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the streaming output logic to Base so it no longer needs to inherit here

Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
Comment threadapps/files/lib/Command/Object/ObjectUtil.php Outdated
Comment threadapps/files/lib/Command/Object/Orphans.php Outdated
Comment threadapps/files/lib/Command/Object/Orphans.php Outdated
@icewind1991icewind1991 mentioned this pull request Mar 28, 2025
Merged
1 task
@icewind1991
feat: add command to get object metadata
c3bc362
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add command to list objects
fcde776
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add command to list orphan objects
f17cf83
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: rework object listing
7d9655d
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: move streaming output helps to command base class
7ce06f4
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991 merged commit 874c283 into masterMar 31, 2025
@icewind1991
icewind1991 deleted the object-store-orphan branch March 31, 2025 12:55
@icewind1991icewind1991 mentioned this pull request Apr 1, 2025
Closed
@icewind1991

icewind1991 commented May 15, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@icewind1991

icewind1991 commented May 15, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

This was referenced May 15, 2025
Merged
Merged
@sorbaughsorbaugh mentioned this pull request May 28, 2025
Closed
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@joshtrichardsjoshtrichards mentioned this pull request Jun 3, 2026
Open
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@come-nccome-nccome-nc approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@PytalPytalAwaiting requested review from Pytal
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@artongeartongeAwaiting requested review from artonge
@nfebenfebeAwaiting requested review from nfebe

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: object storagefeature: occ

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@susnux@come-nc@AndyScherzinger@skjnldsv