Skip to content

fix(IFilenameValidator): correctly handle case insensitivity - #51611

Merged
susnux merged 1 commit into
masterfrom
fix/file-name-validator-case-sensitivity
Mar 24, 2025
Merged

fix(IFilenameValidator): correctly handle case insensitivity#51611
susnux merged 1 commit into
masterfrom
fix/file-name-validator-case-sensitivity

Conversation

@susnux

@susnuxsusnux commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Summary

  • forbidden names and forbidden base names are case insensitive so we need to check all lowercase here.
  • add test that config value is also read case insensitive.

Checklist

@susnuxsusnux added bug 3. to review Waiting for reviews hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. labels Mar 20, 2025
@susnuxsusnux added this to the Nextcloud 32 milestone Mar 20, 2025
@susnux
susnux requested a review from a team as a code ownerMarch 20, 2025 18:04
@susnux
susnux requested review from Altahrim, icewind1991 and sorbaugh and removed request for a teamMarch 20, 2025 18:05
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

- forbidden names and forbidden base names are case **insensitive**
so we need to check all lowercase here.
- add test that config value is also read case insensitive.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/file-name-validator-case-sensitivity branch from bde1194 to 254dd85CompareMarch 21, 2025 00:01
@susnux
susnux requested review from come-nc and removed request for sorbaughMarch 21, 2025 07:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbughotspot: filename handlingFilenames - invalid, portable, blacklisting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@AndyScherzinger@come-nc@skjnldsv