Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(files_sharing): skip expiration notify for invalid share record - #51614
Merged
Conversation
backportbotBot
requested review from
juliusknorr, luka-nextcloud, nickvergessen and provokateurinMarch 20, 2025 18:52
luka-nextcloudforce-pushed
the
backport/50542/stable30
branch
from
March 21, 2025 08:54
4c227c3 to
83e2606Compareluka-nextcloud
marked this pull request as ready for review
March 21, 2025 08:54
luka-nextcloud
approved these changes
Mar 21, 2025
provokateurin
approved these changes
Mar 21, 2025
provokateurin
enabled auto-merge
March 21, 2025 09:00
luka-nextcloud
disabled auto-merge
March 21, 2025 16:38
AndyScherzingerforce-pushed
the
backport/50542/stable30
branch
from
March 22, 2025 16:12
83e2606 to
d5c53a0Compareluka-nextcloudforce-pushed
the
backport/50542/stable30
branch
from
March 27, 2025 10:26
d5c53a0 to
fa0c906Compare| if ($share->getExpirationDate() === null | ||
| || $share->getExpirationDate()->getTimestamp() < $minTime->getTimestamp() | ||
| || $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp()) { | ||
| || $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp() |
Check notice
Code scanning / Psalm
PossiblyNullReference
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloudforce-pushed
the
backport/50542/stable30
branch
from
March 27, 2025 11:56
fa0c906 to
986a570Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50542
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.